Automate users scraping #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may introduce a bug resulting in database inflation (Jira ticket : https://mila-iqia.atlassian.net/browse/SARC-363) |
for revision comparison in `has_changed` method
|
database inflation bug solved :) |
nurbal
commented
Jun 4, 2024
| # MyMila scraping "NotImplementedError" is temporary ignored until we have a working fetching implementation, | ||
| # or a working workaround using CSV cache. | ||
| with using_trace( | ||
| "sarc.ldap.acquire", "fetch_mymila", exception_types=(NotImplementedError,) |
There was a problem hiding this comment.
Je l'ai fait comme ça, de manière à gérer les deux cas:
- en l'absence de fichier CSV de mymila (dans ce cas la lecture du cache échoue), fetch_mymila est appelée, une exception "Not Implemented" est lancée et gracieusement catchée, et MonMila est donc simplement ignoré
- si on a le CSV, il est manuellement placé dans le répertoire de cache et directement lu.
Pour l'heure le traitement de ce fichier est l'objet d'une autre PR ( #120 ) mais pas encore Ok. Donc on ne place simplement pas le CSV en prod et le code fonctionne en l'état.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's goal is to fix some details about
acquire users:NotImplementedExceptionraised byfetch_mymila, until the PR Add mymila fields #120 is finally merged (still some problems parsing the mymila dump csv, with some specific limit cases)